[feature] add describe command #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
facchettos
force-pushed
the
describe
branch
2 times, most recently
from
9209896 to
4e9027d
Compare
facchettos
force-pushed
the
describe
branch
2 times, most recently
from
81d595a to
72df660
Compare
FabianKramm
reviewed
Aug 14, 2024
| namespace = flags.Namespace | ||
| } | ||
|
|
||
| secretName := "vc-config-" + name |
There was a problem hiding this comment.
Should we use find vcluster here?
FabianKramm
reviewed
Aug 14, 2024
| _, err = output.Write(b) | ||
| return err | ||
| } | ||
| fVcluster, err := find.GetVCluster(ctx, rawConfig.CurrentContext, name, namespace, log.Discard) |
There was a problem hiding this comment.
because for the yaml and json output we don't need it
FabianKramm
approved these changes
Aug 14, 2024
zerbitx
reviewed
Aug 14, 2024
zerbitx
approved these changes
Aug 14, 2024
johannesfrey
approved these changes
Aug 14, 2024
loft-bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
* [feat] added describe command * fixed conditions * now uses camelcase (cherry picked from commit 450e528)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Aug 14, 2024
[v0.20] [feature] add describe command (#2055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves eng-4313
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?
Output example :