Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min and max to LimitRange #2088

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

emoreth
Copy link
Contributor

@emoreth emoreth commented Aug 21, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
The LimitRange resource lacks options for min and max.

Please provide a short message that should be published in the vcluster release notes
Add min and max options to LimitRange

What else do we need to know?

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit ae28895
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6703a228d0c75d0008a0ec6c

@FabianKramm
Copy link
Member

@emoreth thanks for creating this PR! With the current implementation this won't have any effect, are you sure this PR is complete since there are no chart changes.

@emoreth emoreth force-pushed the adds_min_and_max_to_limitrange branch from 32fe9c1 to b06bfd4 Compare August 22, 2024 14:03
@emoreth
Copy link
Contributor Author

emoreth commented Aug 22, 2024

Sorry, I missed pushing a file 🤦

@emoreth emoreth force-pushed the adds_min_and_max_to_limitrange branch from b06bfd4 to 3e3db22 Compare August 22, 2024 14:05
@FabianKramm
Copy link
Member

@emoreth thanks for that, you will also need to add that to the config.go and then generate the schema via go run hack/schema/main.go as described in https://github.com/loft-sh/vcluster/tree/main/config . Then I can merge it

@emoreth emoreth force-pushed the adds_min_and_max_to_limitrange branch from 736f716 to efa2545 Compare September 24, 2024 15:19
@emoreth
Copy link
Contributor Author

emoreth commented Sep 30, 2024

@FabianKramm Sorry for the @, but this should be a quick one

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emoreth thanks again! LGTM! Sorry for letting this hang so long

@FabianKramm FabianKramm merged commit 869c78f into loft-sh:main Oct 7, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants