fix: init manifests fail if chart artifact name differs from chart name #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
rohantmp
force-pushed
the
fixHelm-4457
branch
2 times, most recently
from
0925e17 to
27ce172
Compare
removed test that no longer tested anything Signed-off-by: Rohan CJ <rohantmp@gmail.com>
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
rohantmp
force-pushed
the
fixHelm-4457
branch
from
27ce172 to
723b657
Compare
|
ugh, tests passed, but there was a typo in commit message. Ready to review |
FabianKramm
approved these changes
Sep 11, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Sep 16, 2024
[v0.20] Merge pull request #2133 from rohantmp/fixHelm-4457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of ENG-4457
verified manually that bundled charts work with and without a provided name
Notes for reviewer:
helm pull) doesn't matter. The pulled chart will be the only file in that directory.fixes: #2105