Changes fallback ns to vcluster-platform #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
zerbitx
force-pushed
the
ENG-4560
branch
4 times, most recently
from
2eb2c94 to
85c3727
Compare
Adds function to look up loft deployment's namespace
FabianKramm
reviewed
Sep 17, 2024
ThomasK33
reviewed
Sep 17, 2024
FabianKramm
approved these changes
Sep 19, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
zerbitx
pushed a commit
to zerbitx/vcluster
that referenced
this pull request
Sep 19, 2024
Changes fallback ns to vcluster-platform (cherry picked from commit 6cca2e2) # Conflicts: # pkg/platform/clihelper/clihelper.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function to look up loft deployment's namespace
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #ENG-4560
Please provide a short message that should be published in the vcluster release notes
Tries to look up the platform install's deployment to get the namespace rather than assuming "loft" if the user doesn't specify and the flag default isn't vcluster-platform.