-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added bi-directional annotation and label syncing #2215
Merged
FabianKramm
merged 1 commit into
main
from
thomaskosiewski/eng-4808-2-update-all-core-resources-including-customresrouce-with
Oct 10, 2024
Merged
feat: Added bi-directional annotation and label syncing #2215
FabianKramm
merged 1 commit into
main
from
thomaskosiewski/eng-4808-2-update-all-core-resources-including-customresrouce-with
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
ThomasK33
force-pushed
the
thomaskosiewski/eng-4808-2-update-all-core-resources-including-customresrouce-with
branch
2 times, most recently
from
October 9, 2024 17:29
be19453
to
13d0de3
Compare
FabianKramm
reviewed
Oct 10, 2024
FabianKramm
reviewed
Oct 10, 2024
FabianKramm
reviewed
Oct 10, 2024
FabianKramm
reviewed
Oct 10, 2024
FabianKramm
reviewed
Oct 10, 2024
FabianKramm
reviewed
Oct 10, 2024
FabianKramm
reviewed
Oct 10, 2024
FabianKramm
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above
ThomasK33
force-pushed
the
thomaskosiewski/eng-4808-2-update-all-core-resources-including-customresrouce-with
branch
from
October 10, 2024 07:59
13d0de3
to
6276b26
Compare
FabianKramm
approved these changes
Oct 10, 2024
Signed-off-by: Thomas Kosiewski <thomas.kosiewski@loft.sh>
ThomasK33
force-pushed
the
thomaskosiewski/eng-4808-2-update-all-core-resources-including-customresrouce-with
branch
from
October 10, 2024 11:04
6276b26
to
ef07168
Compare
ThomasK33
deleted the
thomaskosiewski/eng-4808-2-update-all-core-resources-including-customresrouce-with
branch
October 18, 2024 08:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind enhancement
/kind feature
/kind documentation
/kind test
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)resolves ENG-4808
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?