feat: require valid admin email for platform start #2217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
ThomasK33
suggested changes
Oct 10, 2024
Comment on lines
+164
to
+179
| func validateEmail(email string) error { | ||
| ret, err := verifier.Verify(email) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if ret.Disposable { | ||
| return fmt.Errorf(`disposable address "%s" not allowed`, email) | ||
| } | ||
|
|
||
| if !ret.HasMxRecords { | ||
| return fmt.Errorf(`address "%s" without MX record not allowed`, email) | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
This will perform SMTP or MX lookups from a CLI, potentially blocking folks in air-gapped or restricted networks from spinning up the platform.
I'd expect this logic in the platform code if connections can be established.
The CLI should only perform a quick sanity check using a regex or comparable mechanics.
FabianKramm
requested changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #ENG-4850