Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Separate volumesnapshot mappers into individual configurations #2229

Conversation

ThomasK33
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind enhancement
/kind feature
/kind documentation
/kind test

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...

What else do we need to know?

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit 00f3708
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/670f86548027d2000877a407

@ThomasK33 ThomasK33 force-pushed the thomaskosiewski/eng-4887-bug-enabling-volumesnapshots-sync-breaks-vcluster-v0210 branch 4 times, most recently from b045554 to c38bf69 Compare October 15, 2024 15:34
@deniseschannon deniseschannon requested a review from a team October 15, 2024 18:15
@rmweir rmweir requested review from rmweir and removed request for a team October 15, 2024 18:21
Copy link
Contributor

@rmweir rmweir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a non-blocking question, otherwise lgtm

Signed-off-by: Thomas Kosiewski <thomas.kosiewski@loft.sh>

bump custom-gcl.yml
@ThomasK33 ThomasK33 force-pushed the thomaskosiewski/eng-4887-bug-enabling-volumesnapshots-sync-breaks-vcluster-v0210 branch from c7a6f4a to 00f3708 Compare October 16, 2024 09:24
@ThomasK33 ThomasK33 merged commit 1bad19d into main Oct 16, 2024
64 checks passed
@ThomasK33 ThomasK33 deleted the thomaskosiewski/eng-4887-bug-enabling-volumesnapshots-sync-breaks-vcluster-v0210 branch October 16, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants