[v0.20] Merge pull request #2240 from rmweir/fix-auth-lock #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior, we were using a kubeconfig client during setup of the platform commands. The client uses the command "vcluster platform token". This would cause an endless loop like the following: 1. you run the "vcluster platform ..." command 2. vcluster makes request to /deployments endpoint, before running the intended command. 3. the k8s client uses vcluster to authenticate the request 4. return to step 2 The request was being made to detect the platform namespace and set it as the default namespace for the backup management command. Now, there is not a default that is set ahead of running the command but if a value was not passed, the CLI will then search for the platform namespace. (cherry picked from commit a5622f9)
ThomasK33
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov0.20:Questions ?
Please refer to the Backport tool documentation