feat: Render control plane ingress spec as template in helm chart #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
reviewed
Nov 22, 2024
There was a problem hiding this comment.
@garryod thanks a lot for the PR! LGTM, but would you mind adding a helm unit test for this so we got that new functionality covered? Also seems some unit tests are failing, would be nice if you could take a look
FabianKramm
reviewed
Nov 22, 2024
Sure thing, should all be resolved now |
FabianKramm
approved these changes
Nov 27, 2024
|
@garryod thanks, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)partially resolves #1760 by rendering the
.Values.controlPlane.ingress.specas a helm template when substituting it into the ingress templatePlease provide a short message that should be published in the vcluster release notes
Allows use of templates in chart
.Values.controlPlane.ingress.specWhat else do we need to know?