fix(cli): clean up clusteroles/bindings, config.json, add prompt #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
rohantmp
force-pushed
the
destroyCommand
branch
from
a0585d8 to
d662e4a
Compare
ThomasK33
approved these changes
Dec 2, 2024
johannesfrey
approved these changes
Dec 2, 2024
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
rohantmp
force-pushed
the
destroyCommand
branch
from
d662e4a to
524671e
Compare
|
Comments accepted and changes pushed. Thanks :) |
ThomasK33
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
ENG-5254
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-5254
resolves ENG-5244
What else do we need to know?
vcluster platform destroy will now prompt the user to type "delete" to confirm destruction, unless the --non-interactive flag is passed
vcluster platform destroy now properly cleans up config.json, and a few clusterroles/bindings it missed before
prompt example:
