Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not sync config on changes on main; do it only releases #2305

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

hidalgopl
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
removes sync-config.yaml workflows, that was copying the config/*.go contents to vcluster-config on each change.
As the result, there was potential mismatch between vcluster.schema.json & config/*.go files in vcluster-config.
Instead, we will generate vcluster.schema.json on each release & copy contents of config/*.go files on one commit.
Then, we can tag this commit with given minor version in the vcluster-config repo.

Signed-off-by: Paweł Bojanowski <pawel.bojanowski@loft.sh>
@hidalgopl hidalgopl requested a review from a team December 2, 2024 12:33
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 01e0ee1
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/674da90e92020600085ea3df

@ThomasK33 ThomasK33 merged commit 9ed8253 into loft-sh:main Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants