set feedback list task_id default to "" instead of None #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxtran
reviewed
Apr 1, 2024
| @@ -59,7 +59,7 @@ def create( | |||
| res = self._post_request(self.feedback_create_url, json_payload) | |||
| return res | |||
|
|
|||
| def list(self, offset: int = 0, limit: int = 50, task_id: str = None) -> httpx.Response: | |||
| def list(self, offset: int = 0, limit: int = 50, task_id: str = "") -> httpx.Response: | |||
| base_url = self._log10_config.url | |||
There was a problem hiding this comment.
should we add a check that if task_id is empty string, then we would not make an api call?
There was a problem hiding this comment.
no, task_id is optional and could be empty. If it's empty, it returns the existing feedback, like the feedback page in GUI.
kxtran
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repro code:
Error due to incorrectly set
task_id=Nonein request url and get 500 internal error.