add default value for LOG10_URL if not set in env #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused function
wenzhe-log10
commented
Oct 18, 2024
| @@ -99,9 +99,6 @@ def post_request(url: str, json_payload: dict = {}) -> requests.Response: | |||
| raise | |||
|
|
|||
|
|
|||
| post_session_request = functools.partial(post_request, url + "/api/sessions", {}) | |||
There was a problem hiding this comment.
remove unused function
kxtran
approved these changes
Oct 18, 2024
Comment on lines
32
to
33
| token = os.environ.get("LOG10_TOKEN") | ||
| org_id = os.environ.get("LOG10_ORG_ID") |
There was a problem hiding this comment.
what do you think of error messages when token and org_id aren't being set?
There was a problem hiding this comment.
added exception handle for 401 http error, similar to what we did in _httpx_utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.