Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py to install dependencies. #620

Closed
wants to merge 3 commits into from
Closed

Fix setup.py to install dependencies. #620

wants to merge 3 commits into from

Conversation

sydp
Copy link
Contributor

@sydp sydp commented Dec 28, 2021

Fixes #619

@sydp
Copy link
Contributor Author

sydp commented Dec 28, 2021

When running python setup.py install, I get the following error:

File "/tmp/easy_install-ntcdk5x3/cryptography-36.0.1/setup.py", line 14, in <module>
    from distutils.command.bdist_msi import bdist_msi
ModuleNotFoundError: No module named 'setuptools_rust'

Seems to be a known issue when installing cryptography as a dependency (pyca/cryptography#6411)

Manually installing setuptools_rust via pip resolves this issue.

@joachimmetz
Copy link
Member

@sydp thx for the suggested changes, but I'll address this differently by changing parse_requirements_from_file to return a list. This needs to be changed in l2tdevtools as well since it generates setup.py.

@sydp sydp deleted the fix_setup branch December 28, 2021 03:35
@sydp
Copy link
Contributor Author

sydp commented Dec 28, 2021

Sounds good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip install doesn't install dependencies
2 participants