FE: Refactor chat control tooltips #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zeroliu
commented
Nov 9, 2024
zeroliu
commented
- Use radix tooltip to implement tooltips in the chat control. It's easier to maintain and handles more edge cases.
- Made chat control icon bigger.
- Made "unsaved history will be lost" message display conditionally based on auto save settings
zeroliu
commented
Nov 9, 2024
| @@ -247,40 +242,24 @@ const ChatInput: React.FC<ChatInputProps> = ({ | |||
|
|
|||
| <div className="chat-input-buttons"> | |||
| {isGenerating && ( | |||
| <Tooltip.Provider delayDuration={0}> | |||
There was a problem hiding this comment.
removed because there is no tooltip for these buttons
logancyang
reviewed
Nov 9, 2024
| </button> */} | ||
| </> | ||
| <TooltipActionButton | ||
| onClick={onSaveAsNote} |
There was a problem hiding this comment.
Shouldn't this be onRefreshVaultContext?
logancyang
reviewed
Nov 9, 2024
| </> | ||
| <TooltipActionButton | ||
| onClick={onSaveAsNote} | ||
| Icon={<UseActiveNoteAsContextIcon className="icon-scaler" />} |
There was a problem hiding this comment.
Since we are updating this, UseActiveNoteAsContextIcon is a legacy name, we can rename it to "RefreshIndexIcon" or something.
There was a problem hiding this comment.
I saw we are using lucide icons. I updated them to use the library instead of custom Icons. WDYT?
There was a problem hiding this comment.
we can follow up to replace the rest of icons in the app.
There was a problem hiding this comment.
@zeroliu That would be great! These were added by a total frontend noob - me. Glad this will be cleaned up now!
zeroliu
force-pushed
the
zero/tooltip-control
branch
from
2d5220d
to
c458837
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.