Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings and chat focus #824

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

zeroliu
Copy link
Contributor

@zeroliu zeroliu commented Nov 16, 2024

This PR includes the following features and bug fixes:

  • Features
    • Added a settings to hide suggested prompts
Screenshot 2024-11-16 at 12 56 53 PM
  • Bug Fixes

    • Open chat command will now properly focus the chat.
      2024-11-16 12 58 04

    • Reopen chat window will inherit the previous chat control settings.
      2024-11-16 12 58 43

  • Dev Ex Improvements

    • Added a settings value context. Chat components can use it directly to avoid props drilling.
    • Removed unused variables and imports.
    • Changed how chat focus is working. Made it more reliable and easier to work with.

@logancyang
Copy link
Owner

As discussed, this is the right direction for this project. We need to refactor to use context more everywhere.

Since the copilot-plus change is coming in, this one will come in after.

@leventov
Copy link

@logancyang you mean that you will release the new project structure as part of the "base" open source version, so you want to merge third-party PRs on top of that structure? What's your ETA for this release?

@logancyang
Copy link
Owner

@leventov Copilot plus alpha will be released today as v2.7.3 if nothing else happens.

@zeroliu zeroliu force-pushed the zero/settings-update branch 2 times, most recently from 682d890 to f439a12 Compare November 23, 2024 18:33
@zeroliu
Copy link
Contributor Author

zeroliu commented Nov 23, 2024

@logancyang I rebased the latest master branch and fixed merge conflicts

@logancyang logancyang merged commit 0e8a3d7 into logancyang:master Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants