feat: support consideration for surrogate pairs #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logaretm
approved these changes
Apr 30, 2023
Thank you for confirming！ We have added a test case for this change |
logaretm
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 Overview
🤓 Code snippets/examples (if applicable)
It appears that the current implementation of the String.length method may not accurately reflect the number of characters in a string containing surrogate pairs.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/length
Specifically, this is the case
https://codepen.io/nao62165/pen/OJBgwjB?editors=1111
With this change, users of surrogate pairs will also receive the expected results.
We hope you will consider this!
The method of using Intl.Segmenter is also mentioned. Segmenter](), but it is not available in FireFox at this time. Spread syntax has been adopted so that more users can use it.
✔ Issues affected