This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
fix: types.d.ts - missing key logdna_url in ConstructorOptions #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smusali
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Looks good to me! Thanks a lot for fixing this, @ibmjanneme!
|
Thanks again for the fix, @ibmjanneme, it's already been released as a part of |
|
Thanks a lot for the update, Samir.
Ragards
Jan
IBM Česká republika, spol. s r.o.
Sídlo: Praha 4, Chodov, V Parku c.or.4,c.p.2294, PSČ 14800
IC: 14890992
Zapsaná v obchodním rejstříku, vedeném Městským soudem
v Praze oddíl C, vložka 692
From: Samir Musali <notifications@github.com>
To: logdna/nodejs <nodejs@noreply.github.com>
Cc: "Jan Němeček" <jan_nemecek@cz.ibm.com>, Mention
<mention@noreply.github.com>
Date: 07/17/2020 06:36 PM
Subject: [EXTERNAL] Re: [logdna/nodejs] fix: types.d.ts - missing
key logdna_url in ConstructorOptions (#96)
Thanks again for the fix, @ibmjanneme, it's already been released as a
part of v3.5.1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.