This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
Convert to tap for testing and update linter
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using a newer ruleset, including `node` and `sensible` plugins. This also removes the linting for mocha since we're moving away from that as a test framework. Semver: patch Ref: LOG-6338
This file is in .gitignore, but since this is not a service, we should not be generating one for anyone who does `npm install`. This commit adds an .npmrc that tells npm not to generate one. Semver: patch Ref: LOG-6338
|
I need to translate the |
|
Do yourself a favor and only look at the commit for the tap changes. Otherwise, reviewers can miss the actual changes in the lib code. |
darinspivey
commented
Jul 15, 2020
darinspivey
force-pushed
the
darinspivey/LOG-6338
branch
2 times, most recently
from
688e438 to
77a57cf
Compare
darinspivey
force-pushed
the
darinspivey/LOG-6338
branch
2 times, most recently
from
2b79ffa to
a2153f1
Compare
darinspivey
commented
Jul 16, 2020
darinspivey
force-pushed
the
darinspivey/LOG-6338
branch
from
a2153f1 to
fbf25dd
Compare
smusali
reviewed
Jul 16, 2020
smusali
reviewed
Jul 16, 2020
smusali
reviewed
Jul 16, 2020
smusali
reviewed
Jul 16, 2020
smusali
reviewed
Jul 16, 2020
smusali
reviewed
Jul 16, 2020
matt-march
reviewed
Jul 16, 2020
matt-march
reviewed
Jul 16, 2020
This moves to `tap` as the test framework, and increases coverage to 100% Semver: patch Ref: LOG-6338
darinspivey
force-pushed
the
darinspivey/LOG-6338
branch
from
fbf25dd to
7fe1c53
Compare
matt-march
approved these changes
Jul 17, 2020
dm36
reviewed
Jul 17, 2020
dm36
reviewed
Jul 17, 2020
smusali
approved these changes
Jul 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package: Convert to
tapfor testingThis moves to
tapas the test framework, and increases coverage.Semver: patch
Ref: LOG-6338
package: Do not create package-lock.json
This file is in .gitignore, but since this is not a service, we
should not be generating one for anyone who does
npm install.This commit adds an .npmrc that tells npm not to generate one.
Semver: patch
Ref: LOG-6338
deps: Upgrade eslint to version 7 and update rule set
We are using a newer ruleset, including
nodeandsensibleplugins.This also removes the linting for mocha since we're moving away
from that as a test framework.
Semver: patch
Ref: LOG-6338