Remove dangerous query default (#224)

logicalclocks · Jan 21, 2021 · 023f97e · 023f97e
1 parent 4c48a3b
commit 023f97e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/python/hsfs/constructor/query.py b/python/hsfs/constructor/query.py
@@ -32,7 +32,7 @@ def __init__(
         feature_store_id=None,
         left_feature_group_start_time=None,
         left_feature_group_end_time=None,
-        joins=[],
+        joins=None,
         filter=None,
     ):
         self._feature_store_name = feature_store_name
@@ -41,7 +41,7 @@ def __init__(
         self._left_features = util.parse_features(left_features)
         self._left_feature_group_start_time = left_feature_group_start_time
         self._left_feature_group_end_time = left_feature_group_end_time
-        self._joins = joins
+        self._joins = joins or []
         self._filter = filter
         self._query_constructor_api = query_constructor_api.QueryConstructorApi()
         self._storage_connector_api = storage_connector_api.StorageConnectorApi(

diff --git a/python/hsfs/statistics_config.py b/python/hsfs/statistics_config.py
@@ -32,7 +32,8 @@ def __init__(
         # use setters for input validation
         self.correlations = correlations
         self.histograms = histograms
-        self._columns = columns
+        # overwrite default with new empty [] but keep the empty list default for documentation
+        self._columns = columns or []
 
     @classmethod
     def from_response_json(cls, json_dict):