[HOPSWORKS-2134] Extend Query constructor with filter capability #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzmeister
force-pushed
the
HOPSWORKS-2134
branch
from
084c525
to
ca66a4f
Compare
moritzmeister
force-pushed
the
HOPSWORKS-2134
branch
from
50b69b1
to
043fcff
Compare
SirOibaf
reviewed
Dec 15, 2020
|
|
||
|
|
||
| class FeatureGroup(feature_group_base.FeatureGroupBase): | ||
| class FeatureGroupBase: |
There was a problem hiding this comment.
I don't understand this refactor. Why putting everything on a single file?
There was a problem hiding this comment.
I am not a huge fan either, but somehow I was getting circular imports because I created the new constructor package. It's quite a pain to debug those, so I can try and find a different solution, but this was the most obvious fix.
docs/templates/query_vs_dataframe.md
Outdated
| ```python | ||
| # create a query | ||
| feature_join = rain_fg.select_all() | ||
| .join(temperature_fg.select_all(), on=["date", "location_id"]) |
There was a problem hiding this comment.
I'd keep this first example simple and also mention how the joining key is selected.
There was a problem hiding this comment.
added more examples also with scala equivalents.
SirOibaf
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving feature groups into single module to resolve circular imports.
Also moving all query constructor related classes into separate package.