Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOPSWORKS-2177] Refactor storage connectors #193

Merged
merged 31 commits into from
Dec 15, 2020

Conversation

SirOibaf
Copy link
Contributor

No description provided.

Copy link
Contributor

@moritzmeister moritzmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some naming changes

python/hsfs/storage_connector.py Outdated Show resolved Hide resolved
python/hsfs/storage_connector.py Outdated Show resolved Hide resolved
SirOibaf and others added 3 commits December 15, 2020 11:53
Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com>
Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com>
…ectorApi.java

Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com>
SirOibaf and others added 2 commits December 15, 2020 11:57
Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com>
Copy link
Contributor

@moritzmeister moritzmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just make sure you have replaced the getByNameAndType everywhere with getByName, I only marked the occurences that I saw here in the code that the PR changes.

@SirOibaf SirOibaf merged commit 42ace4d into logicalclocks:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants