-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOPSWORKS-2177] Refactor storage connectors #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some naming changes
java/src/main/java/com/logicalclocks/hsfs/metadata/StorageConnectorApi.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com>
Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com>
…ectorApi.java Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com>
Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 just make sure you have replaced the getByNameAndType
everywhere with getByName
, I only marked the occurences that I saw here in the code that the PR changes.
No description provided.