Allow to set engine in connection #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it on Databricks and Sagemaker. Since sagemaker now also has pyspark in it's kernels, we also need to be able to set the engine there. |
SirOibaf
approved these changes
Dec 16, 2020
SirOibaf
requested changes
Dec 16, 2020
SirOibaf
approved these changes
Dec 18, 2020
moritzmeister
added a commit
to moritzmeister/feature-store-api
that referenced
this pull request
Jan 19, 2021
Closes logicalclocks#186 (cherry picked from commit 655d1c2)
SirOibaf
pushed a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SageMaker also has PySpark installed in all it's kernels, nevertheless if it is connected to an EMR cluster.