Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add online type getter/setter to Feature #199

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Add online type getter/setter to Feature #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion python/hsfs/feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def name(self, name):

@property
def type(self):
"""Data type of the feature in the feature store.
"""Data type of the feature in the offline feature store.

!!! danger "Not a Python type"
This type property is not to be confused with Python types.
Expand All @@ -82,6 +82,15 @@ def type(self):
def type(self, type):
self._type = type

@property
def online_type(self):
"""Data type of the feature in the online feature store."""
return self._online_type

@online_type.setter
def online_type(self, online_type):
self._online_type = online_type

@property
def primary(self):
"""Whether the feature is part of the primary key of the feature group."""
Expand Down