compute_statistics #213
Merged
compute_statistics #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirOibaf
requested changes
Jan 7, 2021
python/hsfs/feature_group.py
Outdated
| @@ -640,6 +648,27 @@ def commit_delete_record( | |||
| """ | |||
| self._feature_group_engine.commit_delete(self, delete_df, write_options) | |||
|
|
|||
| def compute_statistics(self): | |||
There was a problem hiding this comment.
This is wrong. compute_statistics should be a member of the FeatureGroupBase class so that it can be used also by the on-demand feature groups
SirOibaf
requested changes
Jan 8, 2021
python/hsfs/feature_group.py
Outdated
| @@ -218,6 +218,27 @@ def get_feature(self, name: str): | |||
| f"'FeatureGroup' object has no feature called '{name}'." | |||
| ) | |||
|
|
|||
| def compute_statistics(self): | |||
There was a problem hiding this comment.
Can you please not mix the methods? The rest of the statistics methods start at line 265.
SirOibaf
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.