Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Azure Machine Learning and HDInsight #225

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Add documentation for Azure Machine Learning and HDInsight #225

merged 1 commit into from
Jan 22, 2021

Conversation

steffengr
Copy link

No description provided.

jimdowling
jimdowling requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@jimdowling jimdowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. It would be nice to factor out the repetitive sections (create api key, configure security groups, etc) into standalone files. If it's too hard, it's ok.

docs/hopsworksai/azure/getting_started.md Outdated Show resolved Hide resolved
docs/integrations/hdinsight.md Outdated Show resolved Hide resolved
docs/integrations/hdinsight.md Outdated Show resolved Hide resolved
docs/integrations/hdinsight.md Show resolved Hide resolved
docs/integrations/hdinsight.md Show resolved Hide resolved
docs/integrations/mlstudio_designer.md
@@ -0,0 +1,147 @@
# Azure Machine Learning Designer Integration

Connecting to the Feature Store from the Azure Machine Learning Designer requires setting up a Feature Store API key for the Designer and installing the **HSFS** on the Designer. This guide explains step by step how to connect to the Feature Store from Azure Machine Learning Designer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HSFS python library on the Designer

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really get that comment. ** is a formatting

docs/integrations/mlstudio_designer.md Outdated Show resolved Hide resolved
docs/integrations/mlstudio_designer.md Outdated Show resolved Hide resolved
docs/integrations/mlstudio_notebooks.md Outdated Show resolved Hide resolved
docs/integrations/mlstudio_notebooks.md Show resolved Hide resolved
@steffengr
Copy link
Author

Looks good in general. It would be nice to factor out the repetitive sections (create api key, configure security groups, etc) into standalone files. If it's too hard, it's ok.

I realized this but don't think it should be done as part of this. There's a lot of replication already.

@jimdowling jimdowling merged commit 93225f5 into logicalclocks:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimdowling jimdowling jimdowling approved these changes

@berthoug berthoug Awaiting requested review from berthoug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffengr @jimdowling