Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature group query/join capabilities #3

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Add feature group query/join capabilities #3

merged 3 commits into from
Jan 23, 2020

Conversation

SirOibaf
Copy link
Contributor

Initial PR to add support for querying/joining feature groups

@SirOibaf SirOibaf added the java label Jan 22, 2020
moritzmeister
moritzmeister approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@moritzmeister moritzmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 the only thing, I think some of the methods can be private such as in Query and see my comment about some duplicate code.

java/src/main/java/com/logicalclocks/featurestore/FeatureGroup.java Outdated Show resolved Hide resolved
@SirOibaf
Copy link
Contributor Author

Not sure what you mean about the private methods in the Query class

@moritzmeister moritzmeister merged commit a794af1 into logicalclocks:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzmeister moritzmeister moritzmeister approved these changes

Assignees
No one assigned
Labels
java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SirOibaf @moritzmeister