libssh2_channel_process_startup: Fix unexpected bytes remain after decoding #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coding When libssh2_channel_process_startup is called with an empty message, libssh2 only checks whether the message pointer is not NULL and does not check if message_len is zero. This results in extra bytes being added to the message, resulting in an error on the server side. This is fixed by providing NULL for message when the message length is zero.
logmanoriginal
force-pushed
the
libssh2_channel_shell
branch
from
93479cc to
4612afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When libssh2_channel_process_startup is called with an empty message, libssh2 only checks whether the message pointer is not NULL and does not check if message_len is zero. This results in extra bytes being added to the message, resulting in an error on the server side.
This is fixed by providing NULL for message when the message length is zero.
References #9