Change buffer type for sftp read and write functions from string to byte array #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the data type of the 'buffer' terminals on the SFTP read and write functions from string to byte array as these function can be used to read/write arbitrary binary data and are not limited to strings. This is a breaking change. Callers must update their code to convert from/to string using the 'Byte Array To String' and 'String To Byte Array' functions, respectively. The VI icons were updated to reflect this change and now have a 'binary' glyph. All examples and tests were updated to convert from/to string as needed.
This changes the implementation for libssh2_sftp_read to directly read data into a byte array instead of manually reserving space in memory and then moving it to the array with MoveBlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the data type of the 'buffer' terminals on the SFTP read and write functions from string to byte array as these functions can be used to read/write arbitrary binary data and are not limited to strings.
This is a breaking change. Callers must update their code to convert from/to string using the 'Byte Array To String' and 'String To Byte Array' functions, respectively.