Update libssh2 to 1.11.1 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids test failures when testing against pre-release versions of libssh2.
logmanoriginal
force-pushed
the
libssh2-1.11.1
branch
from
28aa623 to
f3c6d74
Compare
This is a new feature in libssh2 1.11.1 which excludes deprecated APIs when compiling the project. Affected APIs: - libssh2_banner_set - libssh2_session_startup - libssh2_channel_receive_window_adjust - libssh2_channel_handle_extended_data - libssh2_scp_recv None of these APIs have bindings in lvssh2 so it is safe to exclude them. Note that LIBSSH2_NO_DEPRECATED does not actually remove all deprecated APIs but only those that are deprecated for a long time (e.g., libssh2_session_callback_set is deprecated but not removed)
This enables ECDSA support for the WinCNG backend when building libssh2. ECDSA support is a new feature in libssh2 1.11.1 and required Windows 10 or later.
This adds new error codes introduced by libssh 1.11.1 The error codes are mapped to error numbers 5051, 5052, 5053: - 5051: LIBSSH2_ERROR_MAC_FAILURE - 5052: LIBSSH2_ERROR_HASH_INIT - 5053: LIBSSH2_ERROR_HASH_CALC
libssh2_session_callback_set() is deprecated in libssh2-1.11.1 This adds a deprecation warning to the VI description and updates the icon to stand out on the block diagram. The error cluster returns a warning with a brief explanation when the VI is called. Note that libssh2_session_callback_set(), while deprecated, is still available in libssh2-1.11.1.
libssh2_session_callback_set2() was added in libssh2-1.11.1 as a replacement for libssh2_session_callback_set(), which is not type safe. This also updates the extensions library to utilize the new libssh2_cb_generic type and replaces the old function in all callers and the palette. Note that the implementation between *set and *set2 in LabVIEW are practically identical because all instances of libssh2_cb_generic* are simply exposed as pointer-sized integers.
LIBSSH2_KNOWNHOST_KEY_SSHDSS is deprecated in libssh2-1.11.1 This also updates the typedef to add "(deprecated)" to the item name. However, item names are not automatically updated on Ring types.
libssh2_sftp_posix_rename_ex() was added in libssh2-1.11.1. It provides POSIX semantics for rename operations. This means that the file appears to be moved to any services monitoring for file changes [1]. It is not supported by all SSH servers. This also adds more descriptive descriptions to all rename functions. [1]: https://github.com/PowerShell/openssh-portable/blob/v8.1.0.0/PROTOCOL#L380..L395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates libssh2 to 1.11.1 and any API updates.
TODO