Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix: Integrate cover traffic to mix service #920

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Nov 18, 2024

1. What does this PR implement?

This PR integrates the cover traffic module (implemented in #910) to the MixService.

Regarding CoverTrafficSettings, I've seen that some parameters in the CoverTrafficSettings can be derived from parameters in other settings (e.g. num_hops). So, I defined the CoverTrafficExtSettings that contains only parameters that the user must specify. All other parameters are derived from other settings.

2. Does the code have enough context to be clearly understood?

Yes

3. Who are the specification authors and who is accountable for this PR?

@youngjoon-lee @danielSanchezQ

4. Is the specification accurate and complete?

Yes

5. Does the implementation introduce changes in the specification?

No

Checklist

Warning

Do not merge the PR if any of the following is missing:

  • 1. Description added.
  • 2. Context and links to Specification document(s) added.
  • 3. Main contact(s) (developers and specification authors) added
  • 4. Implementation and Specification are 100% in sync including changes. This is critical.
  • 5. Link PR to a specific milestone.

@youngjoon-lee youngjoon-lee merged commit 63c472e into master Nov 28, 2024
6 checks passed
@youngjoon-lee youngjoon-lee deleted the mix-cover-integration branch November 28, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants