Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rpm Installed Yarn #108

Merged
merged 12 commits into from
Aug 6, 2019

Conversation

josh-cogdill
Copy link

No description provided.

package.json Outdated Show resolved Hide resolved
@john-gress john-gress self-assigned this Aug 5, 2019
package.json Outdated Show resolved Hide resolved
@@ -17,12 +17,5 @@
* under the License.
*/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing this file, we could also remove line 20 of src/setup_node_env/index.js to have the same effect. That way, we could leave this code in, it just wouldn't ever be called.

I'm not at all opposed to leaving this as-is though!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that better.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mejarrett mejarrett self-assigned this Aug 5, 2019
@josh-cogdill josh-cogdill merged commit 62fbec4 into logrhythm:7.2.0_NM Aug 6, 2019
sperry94 pushed a commit that referenced this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants