Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PCAP/Attachment download capability #120

Merged
merged 8 commits into from
Oct 3, 2019

Conversation

sperry94
Copy link

@sperry94 sperry94 commented Oct 2, 2019

This PR adds PCAP/Attachment download capability.

Rally Ticket

This PR includes changes from this nm-web-shared PR.

@sperry94 sperry94 changed the base branch from master to 7.2.0_NM October 2, 2019 21:30
@Schatzman
Copy link

Pair reviewed with Seth but still need to build and test

@Schatzman Schatzman self-assigned this Oct 3, 2019
Copy link

@Schatzman Schatzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 pair reviewed with Seth and tested

@sperry94 sperry94 merged commit fcf39e2 into logrhythm:7.2.0_NM Oct 3, 2019
@sperry94 sperry94 deleted the file-download branch October 3, 2019 22:06
sperry94 added a commit that referenced this pull request Jan 30, 2020
* adding file/pcap download capability

* updating packages

* updating dev version of shared package

* updating shared package dev version

* update typescript, fix import

* fixing broken ts build

* sorting file names

* update nm-web-shared version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants