use plugin.stop to return from run #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
|
It would also be helpful to handle this stop when Stud.interval get in a proper shutdown mechanism with wake up, isn't? |
|
@purbon plugin now properly aborts the stud interval 👍 |
|
LGTM |
| @@ -67,4 +68,8 @@ def generate_message(sequence) | |||
| end | |||
| end | |||
|
|
|||
| def stop | |||
| super | |||
jsvd
force-pushed
the
shutdown_using_stop
branch
from
6216ef4 to
955fef5
Compare
|
another review is needed for this, removed super |
|
This is much prettier! LGTM |
|
Merged sucessfully into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
stopto return fromrunaccording to elastic/logstash#3210Depends on elastic/logstash-devutils#32 and elastic/logstash#3812
This implementation still has a problem that, during the hearbeat sleep, there is no way to abort the plugin
runmethod. Therefore a very biginterval_timecan make this plugin hang the shutdown sequenceMaybe an option is to decide to do a Thread.kill if the thread is sleeping?
resolves #8