max max_messages configurable #30
Open
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlambert121
force-pushed
the
max_messages
branch
from
e5d5a49 to
b297b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into issues with this paling failing with a
AWS.SimpleQueueService.BatchEntryIdsNotDistincterror. After some digging it appears (based on my limited knowledge) that this is a threading issue with the AWS SDK. Adding some debugging output to the AWS SDK this is the list of message IDs that are being attempted to be deleted from SQS:rather than the 10 unique ones it received. It looks like this can be fixed when we get to Ruby >= 2. I could be completely wrong on the actual issue, but it does appear this plugin is currently broken but processing messages one at a time does resolve the issue.
More discussion greatly appreciated!