Make usage of the new stop semantics to properly shutdown the plugin

[purbon]

Implements stop to return from run according to elastic/logstash#3210

Depends on elastic/logstash-devutils#32 and elastic/logstash#3812

Fixes #9

[purbon]

Not sure why, but sometimes (looks like randomly) rspec hangs after finishing all the work. looks something like:

most of the times runs without issues. Looks like some issue with my zeromq install, but would be nice to validate.

[talevy]

code looks good. is leaving teardown acceptable? or did we rename this completely to close

I will attempt to re-run on my box and let you know how that goes!

[purbon]

@talevy teardown got renamed to close everywhere.

[purbon]

I run this several times and with the last commit the specs are not hanging anymore.

[jsvd]

@purbon since this is marked as kind of integration test, what do I need to set up in order to test this?

[purbon]

@jsvd a working libzmq installation.

[jsvd]

hum.. I just ran

bundle exec rspec -e interru
Using Accessor#strict_set for specs
Run options:
  include {:full_description=>/interru/}
  exclude {:zeromq=>true, :integration=>true, :redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :export_cypher=>true, :windows=>true}
.

Finished in 0.551 seconds (files took 3.11 seconds to load)
1 example, 0 failures

Randomized with seed 38819

[purbon]

@jsvd don't know why this happen:

purbon-elastic% bundle exec rspec           
Using Accessor#strict_set for specs
Run options: exclude {:zeromq=>true, :integration=>true, :redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :export_cypher=>true, :windows=>true}

All examples were filtered out


Finished in 0.001 seconds (files took 1.77 seconds to load)
0 examples, 0 failures

Randomized with seed 39650

for example.

[jsvd]

by giving -e it ignores the tags
the thing is..should the test pass even without a zmq instance running?

[purbon]

@jsvd without libzmq present in your system test fail, please check if libzmq is there from former times 👍

[jsvd]

LGTM

[elasticsearch-bot]

Merged sucessfully into master!