fix tests related to metadata file moving

lib/logstash/inputs/jdbc.rb

@@ -406,7 +406,7 @@ def ensure_default_metadatafile_location(metadata_new_path)
         # the correct access rights
         ::File.delete(old_default_path.to_path)
         @logger.info("Successfully moved the #{old_default_path.to_path} into #{metadata_new_path.to_path}")
-      rescue e
+      rescue => e
         @logger.warn("Using new metadata file at #{metadata_new_path.to_path} but #{old_default_path} can't be removed.")
       end
     end

spec/inputs/jdbc_spec.rb

@@ -1169,19 +1169,31 @@
     context "when a file exists" do
       before do
         # in a faked HOME folder save a valid previous last_run metadata file
+        allow(ENV).to receive(:[]).and_call_original
         allow(ENV).to receive(:[]).with('HOME').and_return(fake_home)
-        File.open("#{ENV['HOME']}/.logstash_jdbc_last_run", 'w') do |file|
+
+        File.open("#{fake_home}/.logstash_jdbc_last_run", 'w') do |file|
           file.write("--- !ruby/object:DateTime '2022-03-08 08:10:00.486889000 Z'")
         end
       end
+      let(:old_path) { "#{fake_home}/.logstash_jdbc_last_run" }
+      let(:path_data) { LogStash::SETTINGS.get_value("path.data") }
+      let(:new_path) { "#{path_data}/plugins/inputs/jdbc/logstash_jdbc_last_run" }
 
       it "should be moved" do
         plugin.register
-
-        expect(::File.exist?("#{ENV['HOME']}/.logstash_jdbc_last_run")).to be false
-        path = LogStash::SETTINGS.get_value("path.data")
-        full_path = "#{path}/plugins/inputs/jdbc/logstash_jdbc_last_run"
-        expect(::File.exist?(full_path)).to be true
+        expect(::File).to_not exist(old_path)
+        expect(::File).to exist(new_path)
+      end
+      context "if the delete fails" do
+        before(:each) do
+          allow(File).to receive(:delete).and_raise ArgumentError
+        end
+        it "should be still be moved" do
+          plugin.register
+          expect(::File).to exist(old_path) # old still exists
+          expect(::File).to exist(new_path)
+        end
       end
     end
   end