Fix tracking_column regression with Postgresql Numeric types #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to logsatash-input-jdbc 4.3.14, it was possible to use the Postgresql Numeric type as a tracking column across Logstash runs. Since 4.3.14, the deserialization of the sql_last_run parameter has been broken for BigDecimal types, which is how Numeric types are represented as Ruby BigDecimal objects by the Sequel library we use in this plugin. This commit restores this functionality. Fixes: logstash-plugins/logstash-input-jdbc#371
andsel
reviewed
Feb 4, 2020
| @@ -62,7 +62,7 @@ def common_set_initial(method_symbol, default) | |||
|
|
|||
| class NumericValueTracker < ValueTracking | |||
| def set_initial | |||
| common_set_initial(:gcd, 0) | |||
| common_set_initial(:abs, 0) | |||
There was a problem hiding this comment.
I suspect the error before was due to the fact that BigDecimal hasn't gcd method.
There was a problem hiding this comment.
And the gcd(x, 0) was a little bit trickie way to get the absolute value of x
|
LGTM |
|
Thanks @andsel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to logsatash-input-jdbc 4.3.14, it was possible to use
the Postgresql Numeric type as a tracking column across Logstash
runs. Since 4.3.14, the deserialization of the sql_last_run
parameter has been broken for BigDecimal types, which is how
Numeric types are represented as Ruby BigDecimal objects by the
Sequel library we use in this plugin.
This commit restores this functionality.
Fixes: logstash-plugins/logstash-input-jdbc#371