Fix prepared statement reconnect issue #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
reviewed
Apr 7, 2020
yaauie
approved these changes
May 20, 2020
This commit fixes an issue where, if the connection between Logstash and the database fails due to an attempt to use a closed prepared statement. This results in subsequent attempts to use a prepared statement failing when using scheduling, which can only be rectified by restarting Logstash. This commit resets the `statement_prepared` flag, which means that the prepared statement will be recreated upon the next scheduled run. This commit also adds a backtrace to log entries when this issue occurs to provide more visibility into the cause of the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where, if the connection between Logstash
and the database fails due to an attempt to use a closed prepared statement.
This results in subsequent attempts to use a prepared statement
failing when using scheduling, which can only be rectified by restarting Logstash.
This commit resets the
statement_preparedflag, which means that theprepared statement will be recreated upon the next scheduled run.
This commit also adds a backtrace to log entries when this issue occurs to provide
more visibility into the cause of the issue.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/