Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter-jdbc_static.asciidoc #56

Merged
merged 1 commit into from
May 26, 2021

Conversation

tbennett6421
Copy link
Contributor

see #55

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@cla-checker-service
Copy link

cla-checker-service bot commented Nov 30, 2020

💚 CLA has been signed

@tbennett6421
Copy link
Contributor Author

signed cla

@robbavey robbavey added the documentation Improvements or additions to documentation label May 20, 2021
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow response, and thank you for the contribution!

From a content perspective, this makes sense to me

@karenzone Care to double check before I merge and publish?

@karenzone
Copy link
Contributor

@tbennett6421 Thank you for this update, and congratulations on being a first-time contributor for this plugin. We appreciate your contribution.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly and LGTM! 🎉

@karenzone karenzone merged commit 8e9aee1 into logstash-plugins:master May 26, 2021
@karenzone karenzone mentioned this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status:approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants