Massive Refactor! #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Be sure to run the specs with --tag integration as well as without. This depends on setting your Gemfile to point to this PR logstash-plugins/logstash-mixin-rabbitmq_connection#1 |
|
You'll need a gemfile like |
43 tasks
| gemspec | ||
| gem "logstash-mixin-rabbitmq_connection", :path => "../logstash-mixin-rabbitmq_connection" |
There was a problem hiding this comment.
We need to remove this line before publishing.
|
I've made a few minor comments address them and you can merge! excellent refactor @andrewvc ! |
|
Merged sucessfully into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite ready for code review