-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): sign hook payload data #3854
feat(core): sign hook payload data #3854
Conversation
LOG-6073 Core: Signing Hooks Payload Data
https://www.notion.so/silverhand/Generate-Webhook-Signature-41e0f4989d2944aebab78d640d1f2edb
|
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/libraries/hook.test.ts | 📈 +196 Bytes |
packages/core/src/libraries/hook.ts | 📈 +196 Bytes |
packages/core/src/utils/sign.test.ts | 📈 +735 Bytes |
packages/core/src/utils/sign.ts | 📈 +283 Bytes |
packages/integration-tests/src/helpers/index.ts | 📈 +141 Bytes |
packages/integration-tests/src/tests/api/hooks.test.ts | 📈 +2.33 KB |
defc9fd
to
c28ff47
Compare
5ffa9c9
to
aec874a
Compare
e0bf3c9
to
d55a154
Compare
aec874a
to
278be45
Compare
278be45
to
5a38367
Compare
18c378f
to
608ce0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. should we update the integration test to check the header as well?
A test for webhook signature is added. |
3d8f6b6
to
e80604c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
Summary
This PR contains the following updates:
sign
util to sign payload dataTesting
UT & IT & Test locally.
Test with the go sample and get the correct signature
Checklist
.changeset
OR