Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use tsup for building #6354

Merged
merged 3 commits into from
Jul 29, 2024
Merged

refactor: use tsup for building #6354

merged 3 commits into from
Jul 29, 2024

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Jul 28, 2024

Summary

for projects that do NOT need type declarations, tsup (or the underlying esbuild) is extremely faster than tsc. this is helpful for both dev and prod builds.

for type checks, eslint helps us do the job. we need to run tsc manually, added in #6355.

some known limits:

Testing

Performance

less than 1s vs. 10s

352788168-62cdc7bd-f2e9-4c90-8db9-abb6caf0d3cc 352788162-53cfbfa8-86e5-480b-bf68-f120762273d3

Accuracy

locally tested, also should be ok with the current ci

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Jul 28, 2024

COMPARE TO master

Total Size Diff 📈 +3.46 KB

Diff by File
Name Diff
package.json 📈 +22 Bytes
packages/core/nodemon.json 📈 +384 Bytes
packages/core/package.json 📈 +34 Bytes
packages/core/tsconfig.base.json 📈 +215 Bytes
packages/core/tsconfig.build.json 📈 +134 Bytes
packages/core/tsconfig.json 📈 +222 Bytes
packages/core/tsconfig.test.json 📈 +31 Bytes
packages/core/tsup.config.ts 📈 +289 Bytes
packages/core/tsup.dev.config.ts 📈 +284 Bytes
packages/integration-tests/jest.setup.api.js 📈 +249 Bytes
packages/integration-tests/package.json 📈 +26 Bytes
packages/integration-tests/tsup.config.ts 📈 +258 Bytes
packages/schemas/tsconfig.build.alterations.json 📈 +34 Bytes
packages/schemas/tsconfig.build.gen.json 📈 +62 Bytes
pnpm-lock.yaml 📈 +2.61 KB
tsup.shared.config.ts 📈 +216 Bytes

@gao-sun gao-sun force-pushed the gao-use-tsup-for-building branch from 0beca10 to 85c873b Compare July 28, 2024 03:34
@gao-sun gao-sun changed the title Gao use tsup for building refactor: use tsup for building Jul 28, 2024
@github-actions github-actions bot added the enhancement Make it better label Jul 28, 2024
@gao-sun gao-sun marked this pull request as ready for review July 28, 2024 04:25
@gao-sun gao-sun requested a review from a team July 28, 2024 05:01
@gao-sun gao-sun merged commit 05bd162 into master Jul 29, 2024
46 checks passed
@gao-sun gao-sun deleted the gao-use-tsup-for-building branch July 29, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/m
Development

Successfully merging this pull request may close these issues.

2 participants