Skip to content

Commit

Permalink
refactor(rn): mark all native modules as peer dependency
Browse files Browse the repository at this point in the history
mask all native modules as peer dependency
  • Loading branch information
simeng-li committed Feb 19, 2024
1 parent e8e6097 commit 375edec
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 11 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ node_modules/
dist/
web-build/
lib/
android
ios

# Native
*.orig.*
Expand Down
7 changes: 3 additions & 4 deletions packages/rn-sample/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@
"resizeMode": "contain",
"backgroundColor": "#ffffff"
},
"assetBundlePatterns": [
"**/*"
],
"assetBundlePatterns": ["**/*"],
"ios": {
"supportsTablet": true
},
Expand All @@ -25,6 +23,7 @@
},
"web": {
"favicon": "./assets/favicon.png"
}
},
"scheme": "io.logto"
}
}
15 changes: 11 additions & 4 deletions packages/rn-sample/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,22 @@
"version": "0.1.0",
"main": "index.js",
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web"
"dev": "expo start",
"dev:android": "expo start --android",
"dev:ios": "expo start --ios",
"dev:web": "expo start --web",
"run": "expo run",
"android": "expo run:android",
"ios": "expo run:ios"
},
"dependencies": {
"@logto/rn": "workspace:^",
"@react-native-async-storage/async-storage": "^1.22.0",
"expo": "~50.0.6",
"expo-crypto": "^12.8.1",
"expo-secure-store": "^12.8.1",
"expo-status-bar": "~1.11.1",
"expo-web-browser": "^12.8.2",
"react": "18.2.0",
"react-native": "0.73.4"
},
Expand Down
8 changes: 5 additions & 3 deletions packages/rn/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,13 @@
"dependencies": {
"@logto/client": "3.0.0-alpha.2",
"@logto/js": "4.0.0-alpha.2",
"@react-native-async-storage/async-storage": "^1.22.0",
"crypto-es": "^2.1.0",
"js-base64": "^3.7.6"
},
"peerDependencies": {
"@react-native-async-storage/async-storage": "^1.22.0",
"expo-crypto": "^12.8.0",
"expo-secure-store": "^12.8.1",
"expo-web-browser": "^12.8.2",
"js-base64": "^3.7.6"
"expo-web-browser": "^12.8.2"
}
}
21 changes: 21 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 375edec

Please sign in to comment.