Change the cache to hold a pair of token and type instead of only type #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation is that there might be multiple senders with different tokens sending a log with the same type.
idohalevi
suggested changes
May 13, 2019
There was a problem hiding this comment.
@shevah Looks good.
- Let's sit and make sure we are not missing any edge cases
- Let's delete all the deprecated methods (
getOrCreateSenderByType) as we don't create by type anymore. -- I'll bump the release version - I need to follow up with logback + log4j
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is that there might be multiple senders with different tokens sending a log with the same type.
For example, consider a default account and a sub-account having different tokens.
One might like to send a log with the same exact type to both accounts.