Track code coverage #452
Track code coverage #452
Conversation
This reverts commit 2875dfc.
| @@ -12,6 +12,10 @@ | |||
| <PrivateAssets>all</PrivateAssets> | |||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="coverlet.collector" Version="1.2.0"> | |||
There was a problem hiding this comment.
Please add an MSBuild variable named CoverletCollectorPackageVersion here so that we can keep the version consistent across projects easily.
| @@ -0,0 +1,16 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
There was a problem hiding this comment.
Should we move this file into the test directory? This would keep the root directory a little bit tidier
| <ExcludeByAttribute>Obsolete,GeneratedCodeAttribute,CompilerGeneratedAttribute</ExcludeByAttribute> | ||
| <SingleHit>false</SingleHit> | ||
| <UseSourceLink>true</UseSourceLink> | ||
| <IncludeTestAssembly>true</IncludeTestAssembly> |
There was a problem hiding this comment.
Could you explain what these configs are for? Do you know if there is good docs on this stuff? I'm not very familiar with this :)
There was a problem hiding this comment.
I found this document that seems to be relevant: https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md
Are these values just the defaults? If so, can we just remove these configs? If so, can we remove this entire .runsettings file?
| @@ -65,7 +65,23 @@ jobs: | |||
| inputs: | |||
| command: test | |||
| projects: '**/*Tests/*.csproj' | |||
| arguments: '--configuration $(BuildConfiguration)' | |||
| arguments: '--configuration $(BuildConfiguration) --settings $(System.DefaultWorkingDirectory)/CodeCoverage.runsettings --collect:"XPlat Code Coverage" -- RunConfiguration.DisableAppDomain=true' | |||
There was a problem hiding this comment.
Should the DisableAppDomain get moved to the .runsettings file?
|
I tested this and it seems to be working great. I left some comments to better understand the configurations you have. Thanks for opening this! |
|
Thanks for this contribution! |
Remove shadow properties
Addresses #397