Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to dependents UI #572

Merged
merged 17 commits into from
Aug 19, 2020
Merged

Improvements to dependents UI #572

merged 17 commits into from
Aug 19, 2020

Conversation

davidackroyd99
Copy link
Contributor

@davidackroyd99 davidackroyd99 commented Aug 11, 2020 •
edited by loic-sharma
Loading

Addresses #570

Thanks for assigning this issue to me :) Decided to only return the information from the API that is actually required to build up the table, just to make it more performant. If you want me to change any of this I can 👍

@davidackroyd99 davidackroyd99 changed the title Feature/da/dependents ui Improvements to dependents UI Aug 11, 2020
@loic-sharma
Copy link
Owner

This is awesome! I left a few minor comments, I'll merge this in once you address them.

@loic-sharma
Copy link
Owner

loic-sharma commented Aug 17, 2020 •
edited
Loading

Could you also rename this heading to Used By to match nuget.org?

BaGet/src/BaGet.UI/src/DisplayPackage/DisplayPackage.tsx

Line 254 in 9c16b00

<ExpandableSection title="Dependents" expanded={false}>

@davidackroyd99
Copy link
Contributor Author

Think I've resolved all your comments, thanks for being so helpful 👍

@loic-sharma loic-sharma merged commit bc6c1ff into loic-sharma:master Aug 19, 2020
@loic-sharma
Copy link
Owner

Thanks for the contribution, this is awesome! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidackroyd99 @loic-sharma