v2.11.0 #655
Merged
v2.11.0 #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lokesh
commented
Apr 22, 2019
•
lokesh
commented
- Some SVGs display as 0x0 image #552 SVGs without width and height attrs incorrectly sized in IE11 and older Firefox. PR: Remove alpha key press shortcuts #649
- Lightbox closes on press of buttons O/X/C or numpad 3 button #621 Remove alpha kbd aliases for closing and nav (x/c/o/n/p). Keep ESC and arrows. 9ea5e60
- Disable Scrolling scrolls to top when image is clicked. #620 Disable Scrolling scrolls to top when image is clicked. PR: Fix: incorrect position on mobile and overlay width thin when disable scrolling option set to true #650
- Adds empty alt text for placeholder image. PR: Adds empty alt text for placeholder image. #634 by @Nhawdge
- Add aria-labels to prev and next images. Problem and fix by @elohanlon PR: Add aria-labels to prev and next images #651
- visibility hidden/visble on start/end #520 Toggling visibility of elements on open/close revealing intentionally hidden elements. PR: Don't toggle visibility of select, embed, object #652
- Caption links handlers doesn't trigger #635 Caption links handlers doesn't trigger. PR: Re-enable normal click behavior in captions #653
- Fixed images size when changing positionFromTop. Fix by @martijndebruijn PR: Fix: incorrect image size when positionFromTop set #654
…th and height attrs
Remove alpha key press shortcuts
…scrolling option set to true
Fix: incorrect position on mobile and overlay width thin when disable scrolling option set to true
Adds empty alt text for placeholder image.
# Conflicts: # src/js/lightbox.js
Add aria-labels to prev and next images
Don't toggle visibility of select, embed, object
Re-enable normal click behavior in captions
Fix: incorrect image size when positionFromTop set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.