fix: Removed protobuf as a required dependency (feast-dev#4535)

* fix: Removed protobuf as a required dependency Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com> * fix: Removed install-protoc-dependencies target Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com> --------- Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com> Co-authored-by: Bhargav Dodla <bdodla@expediagroup.com>
lokeshrangineni · Sep 18, 2024 · 0fb76e9 · 0fb76e9
1 parent b3c93a0
commit 0fb76e9
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 23 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,9 +1,7 @@
 [build-system]
 requires = [
   "grpcio-tools>=1.56.2,<2",
-  "grpcio>=1.56.2,<2",
-  "mypy-protobuf==3.1",
-  "protobuf==4.24.0",
+  "mypy-protobuf>=3.1",
   "pybindgen==0.22.0",
   "setuptools>=60",
   "setuptools_scm>=6.2",

diff --git a/sdk/python/requirements/py3.10-ci-requirements.txt b/sdk/python/requirements/py3.10-ci-requirements.txt
@@ -572,7 +572,6 @@ proto-plus==1.24.0
     #   google-cloud-datastore
 protobuf==4.25.4
     # via
-    #   feast (setup.py)
     #   google-api-core
     #   google-cloud-bigquery-storage
     #   google-cloud-bigtable

diff --git a/sdk/python/requirements/py3.10-requirements.txt b/sdk/python/requirements/py3.10-requirements.txt
@@ -89,9 +89,7 @@ partd==1.4.2
 prometheus-client==0.20.0
     # via feast (setup.py)
 protobuf==4.25.4
-    # via
-    #   feast (setup.py)
-    #   mypy-protobuf
+    # via mypy-protobuf
 psutil==6.0.0
     # via feast (setup.py)
 pyarrow==17.0.0

diff --git a/sdk/python/requirements/py3.11-ci-requirements.txt b/sdk/python/requirements/py3.11-ci-requirements.txt
@@ -563,7 +563,6 @@ proto-plus==1.24.0
     #   google-cloud-datastore
 protobuf==4.25.4
     # via
-    #   feast (setup.py)
     #   google-api-core
     #   google-cloud-bigquery-storage
     #   google-cloud-bigtable

diff --git a/sdk/python/requirements/py3.11-requirements.txt b/sdk/python/requirements/py3.11-requirements.txt
@@ -87,9 +87,7 @@ partd==1.4.2
 prometheus-client==0.20.0
     # via feast (setup.py)
 protobuf==4.25.4
-    # via
-    #   feast (setup.py)
-    #   mypy-protobuf
+    # via mypy-protobuf
 psutil==6.0.0
     # via feast (setup.py)
 pyarrow==17.0.0

diff --git a/sdk/python/requirements/py3.9-ci-requirements.txt b/sdk/python/requirements/py3.9-ci-requirements.txt
@@ -583,7 +583,6 @@ proto-plus==1.24.0
     #   google-cloud-datastore
 protobuf==4.25.4
     # via
-    #   feast (setup.py)
     #   google-api-core
     #   google-cloud-bigquery-storage
     #   google-cloud-bigtable

diff --git a/sdk/python/requirements/py3.9-requirements.txt b/sdk/python/requirements/py3.9-requirements.txt
@@ -91,9 +91,7 @@ partd==1.4.2
 prometheus-client==0.20.0
     # via feast (setup.py)
 protobuf==4.25.4
-    # via
-    #   feast (setup.py)
-    #   mypy-protobuf
+    # via mypy-protobuf
 psutil==6.0.0
     # via feast (setup.py)
 pyarrow==17.0.0

diff --git a/setup.py b/setup.py
@@ -18,10 +18,9 @@
 import shutil
 import subprocess
 import sys
-
 from pathlib import Path
 
-from setuptools import find_packages, setup, Command
+from setuptools import Command, find_packages, setup
 from setuptools.command.build_ext import build_ext as _build_ext
 from setuptools.command.build_py import build_py
 from setuptools.command.develop import develop
@@ -43,7 +42,6 @@
     "mmh3",
     "numpy>=1.22,<2",
     "pandas>=1.4.3,<3",
-    "protobuf>=4.24.0,<5.0.0",
     "pyarrow>=4",
     "pydantic>=2.0.0",
     "pygments>=2.12.0,<3",
@@ -102,7 +100,7 @@
     "psycopg[binary,pool]>=3.0.0,<4",
 ]
 
-OPENTELEMETRY = ["prometheus_client","psutil"]
+OPENTELEMETRY = ["prometheus_client", "psutil"]
 
 MYSQL_REQUIRED = ["pymysql", "types-PyMySQL"]
 
@@ -139,7 +137,6 @@
 
 GRPCIO_REQUIRED = [
     "grpcio>=1.56.2,<2",
-    "grpcio-tools>=1.56.2,<2",
     "grpcio-reflection>=1.56.2,<2",
     "grpcio-health-checking>=1.56.2,<2",
 ]
@@ -160,6 +157,7 @@
         "virtualenv==20.23.0",
         "cryptography>=35.0,<43",
         "ruff>=0.3.3",
+        "grpcio-tools>=1.56.2,<2",
         "grpcio-testing>=1.56.2,<2",
         # FastAPI does not correctly pull starlette dependency on httpx see thread(https://github.com/tiangolo/fastapi/issues/5656).
         "httpx>=0.23.3",
@@ -403,9 +401,7 @@ def run(self):
     use_scm_version=use_scm_version,
     setup_requires=[
         "grpcio-tools>=1.56.2,<2",
-        "grpcio>=1.56.2,<2",
-        "mypy-protobuf==3.1",
-        "protobuf==4.24.0",
+        "mypy-protobuf>=3.1",
         "pybindgen==0.22.0",
         "setuptools_scm>=6.2",
     ],