Skip to content

Commit

Permalink
feat: Add connection_name field to Snowflake config (feast-dev#4600)
Browse files Browse the repository at this point in the history
Add connection_name field to Snowflake config

Signed-off-by: hkuepers <hanno.kuepers@ratepay.com>
Co-authored-by: hkuepers <hanno.kuepers@ratepay.com>
  • Loading branch information
nanohanno and hkuepers authored Oct 4, 2024
1 parent cc41c9e commit 10ce2aa
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 4 deletions.
5 changes: 4 additions & 1 deletion sdk/python/feast/infra/materialization/snowflake_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ class SnowflakeMaterializationEngineConfig(FeastConfigBaseModel):
""" Type selector"""

config_path: Optional[str] = os.path.expanduser("~/.snowsql/config")
""" Snowflake config path -- absolute path required (Cant use ~)"""
""" Snowflake snowsql config path -- absolute path required (Cant use ~)"""

connection_name: Optional[str] = None
""" Snowflake connector connection name -- typically defined in ~/.snowflake/connections.toml """

account: Optional[str] = None
""" Snowflake deployment identifier -- drop .snowflakecomputing.com"""
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/feast/infra/offline_stores/snowflake.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ class SnowflakeOfflineStoreConfig(FeastConfigBaseModel):
""" Offline store type selector """

config_path: Optional[str] = os.path.expanduser("~/.snowsql/config")
""" Snowflake config path -- absolute path required (Cant use ~)"""
""" Snowflake snowsql config path -- absolute path required (Cant use ~)"""

connection_name: Optional[str] = None
""" Snowflake connector connection name -- typically defined in ~/.snowflake/connections.toml """

account: Optional[str] = None
""" Snowflake deployment identifier -- drop .snowflakecomputing.com """
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/feast/infra/online_stores/snowflake.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ class SnowflakeOnlineStoreConfig(FeastConfigBaseModel):
""" Online store type selector """

config_path: Optional[str] = os.path.expanduser("~/.snowsql/config")
""" Snowflake config path -- absolute path required (Can't use ~)"""
""" Snowflake snowsql config path -- absolute path required (Cant use ~)"""

connection_name: Optional[str] = None
""" Snowflake connector connection name -- typically defined in ~/.snowflake/connections.toml """

account: Optional[str] = None
""" Snowflake deployment identifier -- drop .snowflakecomputing.com """
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/feast/infra/registry/snowflake.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ class SnowflakeRegistryConfig(RegistryConfig):
""" Registry type selector """

config_path: Optional[str] = os.path.expanduser("~/.snowsql/config")
""" Snowflake config path -- absolute path required (Cant use ~) """
""" Snowflake snowsql config path -- absolute path required (Cant use ~)"""

connection_name: Optional[str] = None
""" Snowflake connector connection name -- typically defined in ~/.snowflake/connections.toml """

account: Optional[str] = None
""" Snowflake deployment identifier -- drop .snowflakecomputing.com """
Expand Down

0 comments on commit 10ce2aa

Please sign in to comment.